Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build from git example test #314

Merged
merged 4 commits into from
May 13, 2024

Conversation

mojtaba-esk
Copy link
Contributor

Closes #311

@mojtaba-esk mojtaba-esk requested a review from a team May 2, 2024 16:13
@mojtaba-esk mojtaba-esk self-assigned this May 2, 2024
tty47
tty47 previously approved these changes May 3, 2024
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! 🔥

Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing!

Only one small thing.

Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create a check in SetGitRepo to check if the selected builder is kubernetes?

@mojtaba-esk mojtaba-esk requested a review from smuu May 13, 2024 08:15
@mojtaba-esk mojtaba-esk merged commit fcbab48 into main May 13, 2024
3 of 4 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba/feat-add-build-from-git-example-test branch May 13, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Build from a git repo instead of current local directory
3 participants